[pve-devel] [PATCH] Implement pending change

Dietmar Maurer dietmar at proxmox.com
Mon Oct 27 15:16:44 CET 2014


> >> -delete unused1
> >> So, what happen here ?
> >
> >simply delete the volume.
> 
> But I can't delete it if the vm is running and the disk is attached inside the vm.

It can't be 'unused1' If the disk is used ?! 

> I think your proposal with pending delete is better for this case [PENDING]
> delete : virtio0

confused now.

> >>IMHO, unusedX setting does not belong to VM configuration. It is just
> >>a way to keep track of unused volumes.
> 
> Ok, I'll try to rebase my patch with all your comments.
> I don't have all the corners cases in mind, so I'll see how I can get it work.
> 
> I'll try to send a patch at the end of the week.

Maybe you can fin a way to split the patch into smaller ones. It is quite impossible
to review such large patch.


More information about the pve-devel mailing list