[pve-devel] [PATCH] Implement pending change

[Alexandre DERUMIER]

>>Maybe you can fin a way to split the patch into smaller ones. It is quite impossible
>>to review such large patch.

Yes, I had planned to do it. I had just send the big patch to test.
I'll rework it to match your comments, and with smaller patches.


----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 27 Octobre 2014 15:16:44 
Objet: RE: [pve-devel] [PATCH] Implement pending change 

> >> -delete unused1 
> >> So, what happen here ? 
> > 
> >simply delete the volume. 
> 
> But I can't delete it if the vm is running and the disk is attached inside the vm. 

It can't be 'unused1' If the disk is used ?! 

> I think your proposal with pending delete is better for this case [PENDING] 
> delete : virtio0 

confused now. 

> >>IMHO, unusedX setting does not belong to VM configuration. It is just 
> >>a way to keep track of unused volumes. 
> 
> Ok, I'll try to rebase my patch with all your comments. 
> I don't have all the corners cases in mind, so I'll see how I can get it work. 
> 
> I'll try to send a patch at the end of the week. 

Maybe you can fin a way to split the patch into smaller ones. It is quite impossible 
to review such large patch.