[pve-devel] [PATCH] Implement pending change

[Alexandre DERUMIER]

>> -delete unused1 
>> So, what happen here ? 
>
>simply delete the volume. 

But I can't delete it if the vm is running and the disk is attached inside the vm.

I think your proposal with pending delete is better for this case
[PENDING]
delete : virtio0



>>IMHO, unusedX setting does not belong to VM configuration. It is just a way to keep track 
>>of unused volumes. 

Ok, I'll try to rebase my patch with all your comments. 
I don't have all the corners cases in mind, so I'll see how I can get it work.

I'll try to send a patch at the end of the week.



----- Mail original ----- 

De: "Dietmar Maurer" <dietmar at proxmox.com> 
À: "Alexandre DERUMIER" <aderumier at odiso.com> 
Cc: pve-devel at pve.proxmox.com 
Envoyé: Lundi 27 Octobre 2014 14:07:09 
Objet: RE: [pve-devel] [PATCH] Implement pending change 

> -delete unused0 
> -> I simply delete the vol and remove unused0 
> 
> 
> but 
> 
> -delete unused1 
> So, what happen here ? 

simply delete the volume. 

IMHO, unusedX setting does not belong to VM configuration. It is just a way to keep track 
of unused volumes.