[pmg-devel] [PATCH pmg-api] avast: change 'scan' invocation

[Christian Heutger]

Hi,

great to see, that there was a fix, however, when will it be available? With this nights update to 5.2.4 I thought it will be rolled out, but it wasn’t:

The following packages are currently pending an upgrade:

   pmg-api 5.2-4
   proxmox-spamassassin 3.4.2-3

========================================================================

Package Details:

apt-listchanges: Reading changelogs...
apt-listchanges: Changelogs
---------------------------

--- Changes for pmg-api ---
pmg-api (5.2-4) unstable; urgency=medium

 * limit precision of bayes-score in log

 * Drop sa-awl output from pmg-system-report

 * fix #2232: set rulename for default accept

 * pmg config: fix avast scan executable path documentation



but it‘s still in /usr/share/perl5/PMG/Utils.pm:

open(my $cmd, '-|', '/bin/scan', $dname)

?

Regards,
Christian

>> 
>>> *Von:* Thomas Lamprecht <t.lamprecht at proxmox.com
>>> <mailto:t.lamprecht at proxmox.com>>
>>> *Datum:* 1. Juli 2019 um 17:51:47 MESZ
>>> *An:* Stoiko Ivanov <s.ivanov at proxmox.com
>>> <mailto:s.ivanov at proxmox.com>>, <pmg-devel at pve.proxmox.com
>>> <mailto:pmg-devel at pve.proxmox.com>>
>>> *Kopie:* Christian Heutger <christian at heutger.net
>>> <mailto:christian at heutger.net>>
>>> *Betreff:* *Aw:⁨ [pmg-devel] [PATCH pmg-api] avast: change 'scan'
>>> invocation⁩*
>>> 
>>>> On 5/17/19 2:45 PM, Stoiko Ivanov wrote:
>>>> Change the invocation of avast's 'scan' executable from a hardcoded
>>>> '/bin/scan'
>>>> to 'scan', so that it checks for the executable in the PATH.
>>>> 
>>>> The hardcoded path became apparent, while testing the new upstream
>>>> release
>>>> of avast (3.0.1), where 'scan' got moved from '/bin/scan' to
>>>> '/usr/bin/scan'
>>>> 
>>>> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com
>>>> <mailto:s.ivanov at proxmox.com>>
>>>> ---
>>>> PMG/Utils.pm | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>> 
>>>> diff --git a/PMG/Utils.pm b/PMG/Utils.pm
>>>> index 473a88f..a33ea90 100644
>>>> --- a/PMG/Utils.pm
>>>> +++ b/PMG/Utils.pm
>>>> @@ -459,7 +459,7 @@ sub analyze_virus_avast {
>>>>        "virus analyze (avast) failed: ERROR";
>>>>    };
>>>> 
>>>> -    open(my $cmd, '-|', '/bin/scan', $dname) ||
>>>> +    open(my $cmd, '-|', 'scan', $dname) ||
>>>>        die "$queue->{logid}: can't exec avast scan: $! : ERROR";
>>>> 
>>>>    my $response = '';
>>>> 
>>> 
>>> applied, thanks!
>>> 
>>> 
> 
> -- 
> Mit freundlichen Grüßen
> 
> Thomas Küchenthal
> Technical Director
> 
> LEMARIT GmbH
> Thinking beyond domains.
> 
> Werkstrasse 12
> 24955 Harrislee
> Deutschland
> 
> Tel.Nr: +49(0)461 / 5050 35 - 0
> Fax Nr: +49(0)461 / 5050 35 - 35
> 
> E-Mail: t.kuechenthal at lemarit.com
> Domain: www.lemarit.com
> 
> Amtsgericht Flensburg, HRB 4238 FL
> Geschäftsführer: Martin Küchenthal
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 2348 bytes
Desc: not available
URL: <http://pve.proxmox.com/pipermail/pmg-devel/attachments/20190702/111a4e7c/attachment-0001.bin>