[pbs-devel] applied: [PATCH proxmox] s3 client: fix invalid request for empty delete_objects call
Thomas Lamprecht
t.lamprecht at proxmox.com
Wed Jul 23 15:48:00 CEST 2025
Am 23.07.25 um 11:15 schrieb Christian Ebner:
> The s3 client's object_delete method does not correctly handle cases
> where an empty list of object keys is passed via the parameters,
> resulting in an `invalid request` error.
>
> Handle this by early returning in case of an empty list, thereby also
> skipping the unneeded api request altogether.
>
> This indirectly fixes the snapshot directory cleanup for
> proxmox-backup-client benchmark or aborted backups, where no objects
> have been persisted to the object store within the snapshot prefix
> yet, therefore trying to delete the empty list.
>
> Reported-by: Dominik Csapak <d.csapak at proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> Note: as this indirectly fixes an issue in PBS, latter must be build
> against a bumped version of the proxmox-s3-client.
>
> Further, I'm working on improving the error logging for such invalid
> requests, as they currently do not log the error in the response body
> (if any) in these cases.
>
> proxmox-s3-client/src/client.rs | 4 ++++
> proxmox-s3-client/src/response_reader.rs | 2 +-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>
applied, thanks!
More information about the pbs-devel
mailing list