[pbs-devel] [PATCH proxmox] s3 client: fix invalid request for empty delete_objects call
Christian Ebner
c.ebner at proxmox.com
Wed Jul 23 11:27:15 CEST 2025
On 7/23/25 11:15 AM, Christian Ebner wrote:
> The s3 client's object_delete method does not correctly handle cases
> where an empty list of object keys is passed via the parameters,
> resulting in an `invalid request` error.
>
> Handle this by early returning in case of an empty list, thereby also
> skipping the unneeded api request altogether.
>
> This indirectly fixes the snapshot directory cleanup for
> proxmox-backup-client benchmark or aborted backups, where no objects
> have been persisted to the object store within the snapshot prefix
> yet, therefore trying to delete the empty list.
>
> Reported-by: Dominik Csapak <d.csapak at proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
Forgot to include the independent report of the same issue by Lukas,
which was however incorrectly diagnosed as an of out-of-storage-space issue.
Therefore, please include also:
Reported-by: Lukas Wagner <l.wagner at proxmox.com>
More information about the pbs-devel
mailing list