[pbs-devel] [PATCH proxmox-backup v4 2/6] ui: add support for optional Remote in SyncJob

[Thomas Lamprecht]

Am 29/09/2023 um 14:48 schrieb Hannes Laimer:
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index 48a0c7a9..1d3b021f 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -135,15 +135,25 @@ Ext.define('PBS.window.SyncJobEdit', {
>  
>  		column2: [
>  		    {
> -			fieldLabel: gettext('Source Remote'),
> +			fieldLabel: gettext('Source PBS'),

We avoid using the product abbreviations in UI, docs and marketing
whenever possible.

And I do not like it too much that this is optional, that allows
for easier errors and feels a bit odd w.r.t. how we do things in
the rest of the UI.

>From the top of my head I can see two options (without a bigger
refactoring/split):

1. use "Source Server" as field label and keep it required, make
   the local server a special entry in the selection, i.e., one
   with nothing in the remote id (or "-") and localhost in the
   Host column.

2. Add a radio-group with two options like:

   Source: ( ) Remote Datastore ( ) Local Datastore

   If Local datastore is selected the remote field gets disabled
   completely. This is a bit more explicit w.r.t. UX, but takes
   up more form space.

Maybe there are better ideas, I mean we could also transform this
whole add-sync-job to a wizard style dialog, but I do not want
to move the goalposts of this series such far (as such a change
surely would have a lot of bike shedding potential on its own).