[pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion

Philipp Hufnagl p.hufnagl at proxmox.com
Mon Oct 16 12:48:52 CEST 2023

On 10/13/23 18:29, Thomas Lamprecht wrote:
> Am 13/10/2023 um 16:57 schrieb Philipp Hufnagl:
>> On 10/13/23 13:30, Thomas Lamprecht wrote:
>>> but I'm not sure if we actually want to print anything here, did you
>>> check what the other "action" (i.e., non-GET ones) do, If they all,
>>> or at least most of them, print such reports too it can be fine, but
>>> otherwise this would add inconsistency and simply doing nothing (i.e.,
>>> exiting with SUCCESS) would be enough.
>> You are right! For example 'proxmox-backup-client snapshot notes
>> update' does not produce any output. Ill make a v 2 on Monday removing
>> the output!
> FWIW, I do not have anything about outputting such things, especially
> if other devs/users thinks that's fine, or even desired too.
> But, if we do more such things then a -q/--quiet flag could be nice, e.g.,
> to avoid stray output in scripts using those commands.
> That said, we can always add such output later after you fixed the weird
> Result { null } print, let's keep the scope small for now.

I think you are right here. Since other commands do not output
anything, this command should do that as well for consistency. I think
I should remove the output and we should consider a -v/--verbose flag
in the future.

More information about the pbs-devel mailing list