[pbs-devel] [PATCH proxmox/proxmox-backup v4] add metrics server capability

[Matthias Heiserer]

On 01.02.2022 12:39, Thomas Lamprecht wrote:
> On 01.02.22 12:01, Matthias Heiserer wrote:
>> The patch generally works (connecting with influxdb server, sending data,
>> using api to create config), but some issues/suggestions:
>>
> 
> Thanks for testing, would you consider providing a
>> Tested-by: Matthias Heiserer <m.heiserer at proxmox.com>
> 
> tag even though below notes?

Tested-by: Matthias Heiserer <m.heiserer at proxmox.com>
:)

> 
>> Passing a value to the --enable in api create parameter always results in an
>> error: "Error: parameter verification errors parameter 'enable': Expected
>> boolean value."
> 
> `1` and `0` too?

Yes, tried with 0, 1, 0, "true", "false" and some bogus values, always 
the same error. However, --enable in "api set" works fine.

> 
>>
>> Some personal preferences: I'd prefer if "api get" showed whether a token was
>> set in the config, instead of leaving the field blank.
> 
> Hard to do "inline" as tokens are free-form, the cleanest way would to report
> an extra boolean property on GET ("token-set").

Not sure if I understand you correctly. We know whether a token is 
present by its variant, i.e. Some or None. Couldn't we just map the 
token to e.g. "1"?