[pbs-devel] [PATCH proxmox/proxmox-backup v4] add metrics server capability

[Thomas Lamprecht]

On 01.02.22 12:01, Matthias Heiserer wrote:
> The patch generally works (connecting with influxdb server, sending data,
> using api to create config), but some issues/suggestions:
> 

Thanks for testing, would you consider providing a
> Tested-by: Matthias Heiserer <m.heiserer at proxmox.com>

tag even though below notes?

> Passing a value to the --enable in api create parameter always results in an
> error: "Error: parameter verification errors parameter 'enable': Expected
> boolean value."

`1` and `0` too?

> 
> Some personal preferences: I'd prefer if "api get" showed whether a token was
> set in the config, instead of leaving the field blank.

Hard to do "inline" as tokens are free-form, the cleanest way would to report
an extra boolean property on GET ("token-set").

> When adding a metricserver via "api create" using an already existing id, the
> old server gets overwritten. This might be undesired/problematic. Potential
> fix would be to forbid creating metric servers with an existing id.
> 

Yeah that violates the POST-only-once principle we try to adhere and must not
happen.