[pbs-devel] [PATCH proxmox/proxmox-backup v4] add metrics server capability

[Thomas Lamprecht]

On 01.02.22 14:22, Matthias Heiserer wrote:
> On 01.02.2022 12:39, Thomas Lamprecht wrote:
>> On 01.02.22 12:01, Matthias Heiserer wrote:
>>> Some personal preferences: I'd prefer if "api get" showed whether a token was
>>> set in the config, instead of leaving the field blank.
>>
>> Hard to do "inline" as tokens are free-form, the cleanest way would to report
>> an extra boolean property on GET ("token-set").
> 
> Not sure if I understand you correctly. We know whether a token is present by its variant, i.e. Some or None. Couldn't we just map the token to e.g. "1"?

Sure, the sending site (backend) knows, but for the receiving it'll be always
confusing as it would need to make assumptions of how the implementation works
(coupling). IMO it's just not ideal to multiplex such things.