[pve-devel] [PATCH] iscsi: fix excessive connection test spam on storage monitoring

[Friedrich Weber]

Hi Stelios,

On 11/11/2025 00:25, Stelios Vailakakis wrote:
>> So if I understand correctly, after applying only your hostname patch on
>> top of an up-to-date libpve-storage-perl, you are still seeing the
>> "connection lost" entries on the iSCSI target? Can you double-check the
>> version of libpve-storage-perl (e.g. using `pveversion -v | grep
>> libpve-storage`) on top of which you applied your hostname patch? Could
>> you post the (anonymized) output of `iscsiadm -m node` and `iscsiadm -m
>> session` on nodes 1-4 and 5?
> 
> For clarity, the connection lost entries no longer occur after applying my patch on all previously mentioned PVE stacks as well as within 9.01 which I recently upgraded to.

Since your patch for allowing hostnames in $ISCSI_TARGET_RE was already
applied for PVE9.0 [1], your initial patch doesn't apply cleanly anymore
on top of current pve-storage. Just so we are on the same page regarding
the patch we're discussing, could you send the patch you now applied on
your PVE9 node, rebased on current pve-storage?

> 
> Current environment is proxmox1 - patched, proxmox2 - default. I will show icsiadm output on a "good" proxmox1 vs "bad" proxmox2.
> 
> 12345 is a placeholder for domain, IP addresses irrelevant and made up. I will leave my proxmox2 node unpatched in case we need any more information.
> 
> #Version sanity check
> root at proxmox1:~# pveversion -v | grep 'libpve-storage\|pve-manager'
> pve-manager: 9.0.11 (running version: 9.0.11/3bf5476b8a4699e2)
> libpve-storage-perl: 9.0.13
> 
> root at proxmox2:~# pveversion -v | grep 'libpve-storage\|pve-manager'
> pve-manager: 9.0.11 (running version: 9.0.11/3bf5476b8a4699e2)
> libpve-storage-perl: 9.0.13
> 
> 
> #proxmox1 iscsiadm
> root at proxmox1:~# iscsiadm -m node
> nas.12345.com:3260,4294967295 iqn.2024-01.com.12345.vm-stor
> nas.12345.com:3260,4294967295 iqn.2025-06.com.12345.ssd-vm-stor
> root at proxmox1:~# iscsiadm -m session
> tcp: [1] 192.168.1.10:3260,1 iqn.2024-01.com.12345.vm-stor (non-flash)
> tcp: [2] 192.168.1.10:3260,1 iqn.2025-06.com.12345.ssd-vm-stor (non-flash)
> 
> #proxmox2 icsiadm 
> root at proxmox2:~# iscsiadm -m node
> nas.12345.com:3260,4294967295 iqn.2024-01.com.12345.vm-stor
> nas.12345.com:3260,4294967295 iqn.2025-06.com.12345.ssd-vm-stor
> root at proxmox2:~# iscsiadm -m session
> tcp: [1] 192.168.1.10:3260,1 iqn.2025-06.com.12345.ssd-vm-stor (non-flash)
> tcp: [2] 192.168.1.10:3260,1 iqn.2024-01.com.12345.vm-stor (non-flash)
> 

I don't currently have a test setup where the target advertises a portal
via its hostname, hence my question: Do I understand correctly that
`iscsiadm -m node` shows the hostname, and `iscsiadm -m session` shows
the IP the hostname resolves to? And nas.12345.com resolves to 192.168.1.10?

Best wishes,

Friedrich

[1]
https://lore.proxmox.com/all/175433311513.1860744.14234184790651115057.b4-ty@proxmox.com/
[2] https://pve.proxmox.com/wiki/Developer_Documentation