[pve-devel] [PATCH pve-storage 1/1] fix #6587: parse snapshot names beginning from the first underscore

[Fiona Ebner]

Am 30.07.25 um 12:37 PM schrieb Shannon Sterz:
> Since regular expressions are typically greedy the old regex here
> matched as many underscores as it could (`\S` matches anything that is
> not a whitespace, so also `_`). This lead to an issue where snapshots
> that contained an underscore in their name would be truncated to only
> contain the part of the name after the last underscore.
> 
> Use `[^\s_]` to match everything that is not a whitespace and not the
> underscore character.
> 

Problem is that right now, disk names may contain an underscore as well,
i.e.

pvesm alloc sharedlvm 100 vm-100-disk_with_underscore.qcow2 1M --format
qcow2

which in particular means from a volume name alone like

snap_vm-100-disk_with_underscore_here_s_some_more.qcow2

it is impossible to know how the disk is called and how the volume is.

We either need to change the naming schema for snapshot and align it
with what we do for the dir plugins or restrict the volume names for
qcow2 on LVM (i.e. disallow _ as part of the volume name).