[pve-devel] [PATCH storage 1/5] plugin: fix typo in rebase log message

[Fiona Ebner]

Am 29.07.25 um 9:38 AM schrieb Fabian Grünbichler:
> the format here is of course qcow2, and the actual command was correct, but the
> log message was not.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>

Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>

> ---
>  src/PVE/Storage/Plugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 2bd05bd..99e0e76 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -1437,7 +1437,7 @@ sub volume_snapshot_delete {
>              my $parentpath = $snapshots->{$parentsnap}->{file};
>              print
>                  "$volname: deleting snapshot '$snap' by rebasing '$childsnap' on top of '$parentsnap'\n";
> -            print "running 'qemu-img rebase -b $parentpath -F qcow -f qcow2 $childpath'\n";
> +            print "running 'qemu-img rebase -b $parentpath -F qcow2 -f qcow2 $childpath'\n";
>              $cmd = [
>                  '/usr/bin/qemu-img',
>                  'rebase',

But I'd prefer to join() the command array and print it directly to
avoid such issues altogether.