[pve-devel] [PATCH FOLLOW-UP ha-manager v2 4/4] ha: check for actual disable value during rule checks

[Michael Köppl]

When exclude_disabled_rules was enabled, rules would be excluded from
the check even if the value was actually false, since it still existed.
The check now makes sure that the rule is really disabled before
excluding it.

Signed-off-by: Michael Köppl <m.koeppl at proxmox.com>
---
 src/PVE/HA/Rules.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/HA/Rules.pm b/src/PVE/HA/Rules.pm
index bda0b5d..e756c7d 100644
--- a/src/PVE/HA/Rules.pm
+++ b/src/PVE/HA/Rules.pm
@@ -431,7 +431,7 @@ sub foreach_rule : prototype($$;$) {
         next if !$rule; # skip invalid rules
         next if defined($sid) && !defined($rule->{resources}->{$sid});
         next if defined($type) && $rule->{type} ne $type;
-        next if $exclude_disabled_rules && exists($rule->{disable});
+        next if $exclude_disabled_rules && exists($rule->{disable}) && $rule->{disable};
 
         $func->($rule, $ruleid);
     }
-- 
2.47.2