[pve-devel] [PATCH v2 qemu-server 1/2] drive device: fix regression with missing '/dev/disk/by-id' paths

[Hannes Duerr]

Thanks for the explanation and the hassle with the V2.
And also for @Thomas for appying it, I will go ahead and test it.

On 7/23/25 3:38 PM, Fiona Ebner wrote:
> Am 23.07.25 um 3:33 PM schrieb Fiona Ebner:
>> Am 23.07.25 um 3:21 PM schrieb Fiona Ebner:
>>> With the switch to '-blockdev', it is necessary to explicitly specify
>>> the device ID for SCSI drives, see also [0]. Otherwise, the device
>>> paths in '/dev/disk/by-id' would be missing. For IDE/SATA, the paths
>>> are still present with '-blockdev' without additional changes and
>>> VirtIO block did not have such paths even before. The relevant
>>> 'ide-{cd,hd}' and 'virtio-blk-pci' devices do not seem to have an
>>> option that would be equivalent to the 'scsi-{cd,hd}' 'device_id'
>>> option.
>>>
>>> While the change should be backwards-compatible even with '-drive',
>>> guard it with machine version 10.0 just to be sure.
>>>
>>> [0]: https://gitlab.com/libvirt/libvirt/-/commit/a1dce96236f6d35167924fa7e6a70f58f394b23c
>>>
>>> Fixes: aaf48d8e ("command line: switch to blockdev starting with machine version 10.0")
>>> Co-developed-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
>>> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
>>> ---
>>>
>>> v2: resend with --transfer-encoding=base64
>> Seems like the list auto-converts to
>>
>> Content-Transfer-Encoding: 7bit
>>
>> and breaks it again...
>>
>> I created a blockdev-fixups branch in my qemu-server staff repo for this.
> For completeness, Thomas already applied v1 now, so this is obsolete :)
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>