[pve-devel] applied: [PATCH pve-storage v1] fix #6553: lvmthin: implement volume_rollback_is_possible sub

[Wolfgang Bumiller]

applied, thanks

On Tue, Jul 22, 2025 at 12:26:10PM +0200, Max R. Carrara wrote:
> Because LvmThinPlugin.pm uses LVMPlugin.pm as a base, it inherits the
> `volume_rollback_is_possible()` subroutine added in eda88c94. Its
> implementation however causes snapshot rollbacks to fail with
> "can't rollback snapshot for 'raw' volume".
> 
> Fix this by implementing `volume_rollback_is_possible()`.
> 
> Closes: #6553
> Signed-off-by: Max R. Carrara <m.carrara at proxmox.com>
> ---
>  src/PVE/Storage/LvmThinPlugin.pm | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/PVE/Storage/LvmThinPlugin.pm b/src/PVE/Storage/LvmThinPlugin.pm
> index 6f8a92e..ccefd0e 100644
> --- a/src/PVE/Storage/LvmThinPlugin.pm
> +++ b/src/PVE/Storage/LvmThinPlugin.pm
> @@ -363,6 +363,12 @@ sub volume_snapshot {
>      # disabling autoactivation not needed, as -s defaults to --setautoactivationskip y
>  }
>  
> +sub volume_rollback_is_possible {
> +    my ($class, $scfg, $storeid, $volname, $snap, $blockers) = @_;
> +
> +    return 1;
> +}
> +
>  sub volume_snapshot_rollback {
>      my ($class, $scfg, $storeid, $volname, $snap) = @_;
>  
> -- 
> 2.39.5