[pve-devel] [PATCH widget-toolkit v3 1/2] rrdchart: allow to override the series object
Aaron Lauterer
a.lauterer at proxmox.com
Mon Jul 21 17:08:12 CEST 2025
On 2025-07-21 13:42, Dominik Csapak wrote:
> One nit inline, but aside from that:
>
> Reviewed-by: Dominik Csapak <d.csapak at proxmox.com>
>
> On 7/15/25 16:31, Aaron Lauterer wrote:
>> this way we can keep the current behavior, but also make it possible to
>> finely control a series if needed. For example, if we want a stacked
>> graph, or just a line without fill.
>>
>> Additionally we need to adjust the tooltip renderer to also gather the
>> titles from these directly configured series.
>>
>> Signed-off-by: Aaron Lauterer <a.lauterer at proxmox.com>
>> ---
>> src/panel/RRDChart.js | 53 +++++++++++++++++++++++++++++++++----------
>> 1 file changed, 41 insertions(+), 12 deletions(-)
>>
>> diff --git a/src/panel/RRDChart.js b/src/panel/RRDChart.js
>> index 86cf4e2..3b41ae6 100644
>> --- a/src/panel/RRDChart.js
>> +++ b/src/panel/RRDChart.js
>> @@ -118,13 +118,33 @@ Ext.define('Proxmox.widget.RRDChart', {
>> suffix = 'B/s';
>> }
>> - let prefix = item.field;
>> - if (view.fieldTitles &&
>> view.fieldTitles[view.fields.indexOf(item.field)]) {
>> - prefix =
>> view.fieldTitles[view.fields.indexOf(item.field)];
>> + let value = record.get(item.field);
>> + if (value === null) {
>> + tooltip.setHtml('No Data');
>
> nit: this change seems a bit unrelated? we did just put it in
> convertToUnits previously, and did not check the value before...
I forgot to mention in the commit msg why this is happening. In the next
version, it will be explained.
in short: since stacked charts will also draw data points even if there
is no data, we need to catch that to avoid errors later in the tooltip
renderer.
More information about the pve-devel
mailing list