[pve-devel] applied: [PATCH common] tools: dump logfile: fix result type in case the file cannot be opened

Thomas Lamprecht t.lamprecht at proxmox.com
Thu Jul 17 21:27:14 CEST 2025


On Thu, 17 Jul 2025 18:50:01 +0200, Friedrich Weber wrote:
> The second return value of dump_logfile should be a reference to an
> array of hash references (one per log line), but in case the file
> cannot be opened, it currently directly returns a reference to a hash.
> 
> As a result, the /nodes/{node}/tasks/{upid}/log endpoint response does
> not match the schema in case the task log cannot be opened (for
> example, does not exist). This was reported in enterprise support, as
> it trips up external monitoring tools that query this endpoint.
> 
> [...]

Applied, thanks!

[1/1] tools: dump logfile: fix result type in case the file cannot be opened
      (no commit info)




More information about the pve-devel mailing list