[pve-devel] [PATCH manager v3 2/2] ui: backup job details: show notification-mode instead of legacy keys

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 15 21:59:04 CEST 2025


Am 14.07.25 um 10:42 schrieb Lukas Wagner:
> On  2025-07-14 10:30, Gabriel Goller wrote:

>> Make we should change the Makefile to run `proxmox-biome check`?
> 
> Maybe, but I think a separate make target could make more sense than including it
> in `make check`. The latter is also run during a package build process and it would
> be quite annoying to fail that because of a trivial formatting issue. We also don't do
> that for Rust, neither for clippy nor rustfmt.

+1

If, we should IMO only warn on code failing a formatting check.

> What definitely would make sense is to add biome format/check --write to the `make tidy`
> target, at the moment we seem to only run perltidy there.

Yeah, that's still missing. Any input on target name? I used `tidy` due to
correlation with perltidy's name, but would something else be more sensible
here? 




More information about the pve-devel mailing list