[pve-devel] [PATCH qemu-server 3/4] qcow2: add external snapshot support

DERUMIER, Alexandre alexandre.derumier at groupe-cyllene.com
Tue Jul 15 16:21:59 CEST 2025


> +        rename($src_file_blockdev->{filename},
> $target_file_blockdev->{filename});
>>
>>^ This seems out of place. This does not make sense for all storages
>>and
>>should already have happened via PVE::Storage::rename_snapshot(), no?
>>You don't want to literally rename block device nodes?

ah sorry, this is an left-over of a previous initial patch serie.It's
indeed done in rename_snapshot().

it need to be removed





More information about the pve-devel mailing list