[pve-devel] [PATCH installer v4 3/8] close #5887: add sanity check for LVM swapsize

[Michael Köppl]

On 7/11/25 19:54, Thomas Lamprecht wrote:
> Am 11.07.25 um 18:27 schrieb Michael Köppl:
>> Check that the configured swapsize is not greater than hdsize / 8 as
>> stated in the admin guide [0]. Define the behavior for the auto-installer as
>> well as the TUI and GUI installers.
>>
>> [0] https://pve.proxmox.com/pve-docs/pve-admin-guide.html#advanced_lvm_options
>>
>> Signed-off-by: Michael Köppl <m.koeppl at proxmox.com>
>> ---
>>  Proxmox/Install.pm                            |  8 +++++
>>  proxinstall                                   |  4 ++-
>>  proxmox-auto-installer/src/utils.rs           |  8 +++++
>>  proxmox-auto-installer/tests/parse-answer.rs  |  1 +
>>  .../lvm_swapsize_greater_than_hdsize.json     |  3 ++
>>  .../lvm_swapsize_greater_than_hdsize.toml     | 16 +++++++++
>>  proxmox-installer-common/src/disk_checks.rs   | 33 ++++++++++++++++++-
>>  proxmox-tui-installer/Cargo.toml              |  1 +
>>  proxmox-tui-installer/src/views/bootdisk.rs   | 10 +++++-
>>  9 files changed, 81 insertions(+), 3 deletions(-)
>>  create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.json
>>  create mode 100644 proxmox-auto-installer/tests/resources/parse_answer_fail/lvm_swapsize_greater_than_hdsize.toml
>>
> 
> this one doesn't apply, seems something broken or amiss related to
> proxmox-installer-common/src/disk_checks.rs, please re-check this.

Took some time to figure out why this didn't apply, only to find out
that I made a mistake during preparation of the series. Sorry about
that. Sent an updated v5 [0]. Double-checked this time that all patches
apply!

[0]
https://lore.proxmox.com/pve-devel/20250715094021.154914-1-m.koeppl@proxmox.com