[pve-devel] [PATCH widget-toolkit v2 1/1] network: optionally show alternative interface names
Dominik Csapak
d.csapak at proxmox.com
Tue Jul 15 11:07:48 CEST 2025
add a new (hidden by default) column for the interface names, and show
them when editing an existing interface with such alternative names.
Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
---
no changes from v1
src/node/NetworkEdit.js | 19 +++++++++++++++++++
src/node/NetworkView.js | 20 ++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/src/node/NetworkEdit.js b/src/node/NetworkEdit.js
index b8e23f9..cd9dc7c 100644
--- a/src/node/NetworkEdit.js
+++ b/src/node/NetworkEdit.js
@@ -5,6 +5,9 @@ Ext.define('Proxmox.node.NetworkEdit', {
// Enable to show the VLAN ID field
enableBridgeVlanIds: false,
+ // Show alternative names below normal name
+ showAltNames: false,
+
initComponent: function () {
let me = this;
@@ -363,6 +366,14 @@ Ext.define('Proxmox.node.NetworkEdit', {
},
);
+ if (me.showAltNames && !me.isCreate) {
+ column1.push({
+ xtype: 'displayfield',
+ name: 'altnames',
+ fieldLabel: gettext("Alternative Names"),
+ });
+ }
+
if (me.iftype === 'OVSBond') {
column1.push(
{
@@ -449,6 +460,14 @@ Ext.define('Proxmox.node.NetworkEdit', {
});
return;
}
+
+ if (data.altnames) {
+ if (Ext.isArray(data.altnames)) {
+ data.altnames = data.altnames.join('<br>');
+ }
+ } else {
+ me.down('field[name=altnames]').setVisible(false);
+ }
me.setValues(data);
me.isValid(); // trigger validation
},
diff --git a/src/node/NetworkView.js b/src/node/NetworkView.js
index cf8e6b7..0c62388 100644
--- a/src/node/NetworkView.js
+++ b/src/node/NetworkView.js
@@ -4,6 +4,7 @@ Ext.define('proxmox-networks', {
'active',
'address',
'address6',
+ 'altnames',
'autostart',
'bridge_ports',
'cidr',
@@ -33,6 +34,9 @@ Ext.define('Proxmox.node.NetworkView', {
showApplyBtn: false,
+ // if true, the altnames column will be shown by default
+ showAltNames: false,
+
// for options passed down to the network edit window
editOptions: {},
@@ -103,6 +107,7 @@ Ext.define('Proxmox.node.NetworkView', {
nodename: me.nodename,
iface: rec.data.iface,
iftype: rec.data.type,
+ showAltNames: me.showAltNames,
...me.editOptions,
listeners: {
destroy: () => reload(),
@@ -278,6 +283,21 @@ Ext.define('Proxmox.node.NetworkView', {
sortable: true,
dataIndex: 'iface',
},
+ {
+ header: gettext("Alternative Names"),
+ dataIndex: 'altnames',
+ hidden: !me.showAltNames,
+ width: 140, // enough space for 'enx<MAC>'
+ renderer: (value) => {
+ if (!value) {
+ return '';
+ }
+ if (Ext.isArray(value)) {
+ return value.map(Ext.htmlEncode).join('<br>');
+ }
+ return Ext.htmlEncode(value);
+ },
+ },
{
header: gettext('Type'),
sortable: true,
--
2.39.5
More information about the pve-devel
mailing list