[pve-devel] [PATCH manager] www: backup job detail: style fixups using proxmox-biome
Gabriel Goller
g.goller at proxmox.com
Mon Jul 14 11:48:04 CEST 2025
On 14.07.2025 10:45, Lukas Wagner wrote:
>Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
>---
>
>Notes:
> Mea culpa, I did not know that 'make check' does not check for
> formatting issues.
>
> www/manager6/dc/BackupJobDetail.js | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js
>index 464bb558..67ec5273 100644
>--- a/www/manager6/dc/BackupJobDetail.js
>+++ b/www/manager6/dc/BackupJobDetail.js
>@@ -215,7 +215,7 @@ Ext.define('PVE.dc.BackupInfo', {
> let mailto = record?.mailto;
> let mailnotification = record?.mailnotification ?? 'always';
>
>- if ((value === 'auto' && mailto === undefined) || (value === 'notification-system')) {
>+ if ((value === 'auto' && mailto === undefined) || value === 'notification-system') {
> return gettext('Use global notification settings');
> } else if (mailnotification === 'always') {
> return gettext('Always send email');
>@@ -395,7 +395,9 @@ Ext.define('PVE.dc.BackupInfo', {
> let notificationMode = values['notification-mode'] ?? 'auto';
> let mailto = values.mailto;
>
>- let hideRecipients = (notificationMode === 'auto' && mailto === undefined) || (notificationMode === 'notification-system');
>+ let hideRecipients =
>+ (notificationMode === 'auto' && mailto === undefined) ||
>+ notificationMode === 'notification-system';
> vm.set('hideRecipients', hideRecipients);
>
> // selection Mode depends on the presence/absence of several keys
>--
Looks good to me:
Reviewed-by: Gabriel Goller <g.goller at proxmox.com>
Sorry for not noticing earlier.
More information about the pve-devel
mailing list