[pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Jul 8 14:50:15 CEST 2025


Am 08.07.25 um 13:35 schrieb DERUMIER, Alexandre:
>>> okay, that means we instead need to become more strict with 'snapext'
>>> storages and restrict the volnames there.. maybe to (vm-|base-)-XXX-
>>> *.fmt?
> 
>>> that means only allowing such names when allocating volumes, and
>>> filtering
>>> when listing images..
>>>
>>> since we want to make that property fixed anyway, we don't have to
>>> worry
>>> about existing images..
>>>
>>> does that sound okay?
> 
> yes, I was thinking about the same, as it's a new fixed feature.
> 
> I'll implement it

Can we please use an actually telling name though? As "ext" is quite
often used as term for "extension", and we really win nothing with
doing this.

Strongly preferring words to be spelled out in full and separated with
hyphens, instead of something else or being glued together like here.

Like "snapshot-external" or "external-snapshots". This is just an
option in the storage config, not for each volume, so we really do
not need to optimize option name length here.




More information about the pve-devel mailing list