[pve-devel] [PATCH pve-storage 08/10] qcow2: add external snapshot support
Fabian Grünbichler
f.gruenbichler at proxmox.com
Tue Jul 8 12:59:20 CEST 2025
> DERUMIER, Alexandre <alexandre.derumier at groupe-cyllene.com> hat am 08.07.2025 12:04 CEST geschrieben:
>
>
> > +my sub alloc_backed_image {
> > + my ($class, $storeid, $scfg, $volname, $backing_snap) = @_;
> > +
> > + my $path = $class->path($scfg, $volname, $storeid);
> > + my $backing_path = $class->path($scfg, $volname, $storeid,
> > $backing_snap);
>
> >>should we use a relative path here like we do when doing a linked
> >>clone? else
> >>it basically means that it is no longer possible to move the storage
> >>mountpoint,
> >>unless I am mistaken?
>
> ah, it doesn't playing fine with snapshots directory, because current
> is renamed && moved to snapshot directory, so it's breaking the
> relative path.
okay, that means we instead need to become more strict with 'snapext'
storages and restrict the volnames there.. maybe to (vm-|base-)-XXX-*.fmt?
that means only allowing such names when allocating volumes, and filtering
when listing images..
since we want to make that property fixed anyway, we don't have to worry
about existing images..
does that sound okay?
More information about the pve-devel
mailing list