[pve-devel] [PATCH manager v3 2/3] ui: ha: remove ha groups from ha resource components

[Daniel Kral]

Remove the HA group column from the HA Resources grid view and the HA
group selector from the HA Resources edit window, as these will be
replaced by semantically equivalent HA node affinity rules in the next
patch.

Add the field 'failback' that is moved to the HA Resources config as
part of the migration from groups to node affinity rules.

Signed-off-by: Daniel Kral <d.kral at proxmox.com>
---
 www/manager6/ha/ResourceEdit.js | 16 ++++++++++++----
 www/manager6/ha/Resources.js    | 17 -----------------
 www/manager6/ha/StatusView.js   |  1 -
 3 files changed, 12 insertions(+), 22 deletions(-)

diff --git a/www/manager6/ha/ResourceEdit.js b/www/manager6/ha/ResourceEdit.js
index 1048ccca..428672a8 100644
--- a/www/manager6/ha/ResourceEdit.js
+++ b/www/manager6/ha/ResourceEdit.js
@@ -11,7 +11,7 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
         }
         delete values.vmid;
 
-        PVE.Utils.delete_if_default(values, 'group', '', me.isCreate);
+        PVE.Utils.delete_if_default(values, 'failback', '1', me.isCreate);
         PVE.Utils.delete_if_default(values, 'max_restart', '1', me.isCreate);
         PVE.Utils.delete_if_default(values, 'max_relocate', '1', me.isCreate);
 
@@ -110,9 +110,17 @@ Ext.define('PVE.ha.VMResourceInputPanel', {
 
         me.column2 = [
             {
-                xtype: 'pveHAGroupSelector',
-                name: 'group',
-                fieldLabel: gettext('Group'),
+                xtype: 'proxmoxcheckbox',
+                name: 'failback',
+                fieldLabel: gettext('Failback'),
+                autoEl: {
+                    tag: 'div',
+                    'data-qtip': gettext(
+                        'Enable if HA resource should automatically adjust to HA rules.',
+                    ),
+                },
+                uncheckedValue: 0,
+                value: 1,
             },
             {
                 xtype: 'proxmoxKVComboBox',
diff --git a/www/manager6/ha/Resources.js b/www/manager6/ha/Resources.js
index e8e53b3b..097097dc 100644
--- a/www/manager6/ha/Resources.js
+++ b/www/manager6/ha/Resources.js
@@ -136,23 +136,6 @@ Ext.define('PVE.ha.ResourcesView', {
                     renderer: (v) => (v === undefined ? '1' : v),
                     dataIndex: 'max_relocate',
                 },
-                {
-                    header: gettext('Group'),
-                    width: 200,
-                    sortable: true,
-                    renderer: function (value, metaData, { data }) {
-                        if (data.errors && data.errors.group) {
-                            metaData.tdCls = 'proxmox-invalid-row';
-                            let html = Ext.htmlEncode(
-                                `<p>${Ext.htmlEncode(data.errors.group)}</p>`,
-                            );
-                            metaData.tdAttr =
-                                'data-qwidth=600 data-qtitle="ERROR" data-qtip="' + html + '"';
-                        }
-                        return value;
-                    },
-                    dataIndex: 'group',
-                },
                 {
                     header: gettext('Description'),
                     flex: 1,
diff --git a/www/manager6/ha/StatusView.js b/www/manager6/ha/StatusView.js
index 3e3205a5..a3ca9fdf 100644
--- a/www/manager6/ha/StatusView.js
+++ b/www/manager6/ha/StatusView.js
@@ -78,7 +78,6 @@ Ext.define(
                 'status',
                 'sid',
                 'state',
-                'group',
                 'comment',
                 'max_restart',
                 'max_relocate',
-- 
2.39.5