[pve-devel] [PATCH proxmox-perl-rs v4 3/5] pve-rs: sdn: fabrics: add frr config generation
Wolfgang Bumiller
w.bumiller at proxmox.com
Fri Jul 4 15:31:48 CEST 2025
On Fri, Jul 04, 2025 at 03:23:14PM +0200, Stefan Hanreich wrote:
> On 7/4/25 15:14, Wolfgang Bumiller wrote:
>
> [snip]
>
> >> +
> >> + /// Class method: Return all FRR daemons that need to be enabled for this fabric configuration
> >> + /// instance.
> >
> > Method*
> >
> > Daemons? Or would "services" make more sense (and a `.service` suffix?)
>
> It's a bit weird with FRR, there's only frr.service and it starts
> daemons based on the config in /etc/frr/daemons - hence why I think
> daemons is more fitting.
Ah okay, didn't realize this was about a config file. (Maybe link the
docs or mention the file in the doc comment?)
>
> [snip]
More information about the pve-devel
mailing list