[pve-devel] [PATCH qemu-server v2 15/49] mirror: code style: avoid masking earlier declaration of $op
Fiona Ebner
f.ebner at proxmox.com
Tue Jul 1 17:40:35 CEST 2025
Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
---
src/PVE/QemuServer/BlockJob.pm | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/PVE/QemuServer/BlockJob.pm b/src/PVE/QemuServer/BlockJob.pm
index 0013bde6..d26bcb01 100644
--- a/src/PVE/QemuServer/BlockJob.pm
+++ b/src/PVE/QemuServer/BlockJob.pm
@@ -179,15 +179,15 @@ sub qemu_drive_mirror_monitor {
# try to switch the disk if source and destination are on the same guest
print "$job_id: Completing block job...\n";
- my $op;
+ my $completion_command;
if ($completion eq 'complete') {
- $op = 'block-job-complete';
+ $completion_command = 'block-job-complete';
} elsif ($completion eq 'cancel') {
- $op = 'block-job-cancel';
+ $completion_command = 'block-job-cancel';
} else {
die "invalid completion value: $completion\n";
}
- eval { mon_cmd($vmid, $op, device => $job_id) };
+ eval { mon_cmd($vmid, $completion_command, device => $job_id) };
my $err = $@;
if ($err && $err =~ m/cannot be completed/) {
print "$job_id: block job cannot be completed, trying again.\n";
--
2.47.2
More information about the pve-devel
mailing list