[pve-devel] applied: [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm
Dominik Csapak
d.csapak at proxmox.com
Tue Jul 1 13:55:44 CEST 2025
On 6/3/25 14:20, Shan Shaji wrote:
> When the `default` property was selected inside the realm of the web UI,
> the app's login page was not showing the default realm instead,
> it was always showing PAM.
>
> To reproduce, follow the following steps:
> on the web UI go to Datacenter -> Realms and edit another realm than
> PAM, like PVE. There you can tick the "Default" checkbox. Now go to
> the app and try adding the domain, `PAM` will be selected as default.
>
> This patch series fixes the issue by adding the `default` property
> to the `PveAccessDomainModel` and implementing the necessary
> check in the `_getAccessDomains` function.
>
> History
> ==========
>
> v2: https://lore.proxmox.com/pve-devel/20250526154137.116322-1-s.shaji@proxmox.com/T/#t
>
> changes since v2:
> * removed "This commit" string from commit messages.
> * fixed `StateError` in `singleWhere` function which can happen
> when both conditions are true.
> * If a realm is already saved then that selection will have priority.
>
> proxmox_login_manager:
>
> Shan Shaji (1):
> fix #6409: add `isDefaultRealm` check to pre-select realm in login
> form
>
> lib/proxmox_login_form.dart | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>
> proxmox_dart_api_client:
>
> Shan Shaji (1):
> fix #6409: add `default` property to `PveAccessDomainModel`
>
> lib/src/models/pve_access_domain_model.dart | 5 +++++
> 1 file changed, 5 insertions(+)
>
>
> Summary over all repositories:
> 2 files changed, 8 insertions(+), 1 deletions(-)
>
applied both patches with michaels r-b and t-b, thanks!
More information about the pve-devel
mailing list