[pve-devel] [PATCH qemu-server 18/31] blockdev: add change_medium() helper

[Fiona Ebner]

Am 01.07.25 um 09:30 schrieb DERUMIER, Alexandre via pve-devel:
> Another thing, 
> 
> if the vm is start with cdrom=none,  then you switch to an iso,
> 
> the throttle group is not generated (+the autogenerated nodenames)

Thank you for testing!

AFAICS, the throttle group is already generated at VM start, but then
not re-generated. It already works after the changes you and Fabian
suggested for the attach() and detach() helpers, as the previous
throttle group is properly removed beforehand then.

But I think, I'll also go for not generating the throttle group for
'none' in the first place. It's not used if there is no associated
blockdev, and the limits can always change together with changing the
medium (as both happen by updating the VM config line/qm set), so it
just makes more sense to only generate it when there is an associated
blockdev. Or do you see any problem with that?