[pve-devel] [PATCH qemu-server 07/31] backup: use blockdev for fleecing images

[Fiona Ebner]

Am 30.06.25 um 12:15 schrieb Fabian Grünbichler:
> On June 27, 2025 5:57 pm, Fiona Ebner wrote:
>> +my sub fleecing_node_name {
>> +    my ($type, $drive_id) = @_;
>> +
>> +    if ($type eq 'fmt') {
>> +        return "drive-$drive_id-fleecing"; # this is the top node for fleecing
>> +    } elsif ($type eq 'file') {
>> +        return "$drive_id-fleecing-file"; # drop the "drive-" prefix to be sure, max length is 31
> 
> should we use `e-...` instead of `...-file`, to have similar encoding as
> the regular block nodes? or even let get_node_name handle it by adding a
> `top` type to it?

I mean, we could, but it's not encoded, so I don't really see the
benefit to go with that schema. It just makes checking if it's a
fleecing top node slightly harder.

Adding a 'top' type would just mean overriding it on the call side.
Currently, generate_{file,format}_blockdev simply call get_node_name()
with type '{file,fmt}' so that seems nice to me. When using a 'top'
type, generate_format_blockdev would also need to check $options, so
it'd just spread out the logic to one more place.