[pve-devel] [PATCH pve_flutter_frontend v3] ui: enable noVNC console on iOS
Shan Shaji
s.shaji at proxmox.com
Thu Aug 14 09:54:27 CEST 2025
Thank you so much for the review. I am using the samne versions
flutter 3.29 and dart 3.7.2. I will create another patch without
the formating changes to better identify the changes.
After the patch is applied i can send another patch by runnning
the `dart format .` command on master.
On Wed Aug 13, 2025 at 3:36 PM CEST, Dominik Csapak wrote:
>
>
> On 8/13/25 10:29, Shan Shaji wrote:
> > The noVNC console was disabled in iOS and was only available in
> > android.
> >
> > To fix the issue enabled the noVNC console view on iOS devices. The
> > changes also includes a refactor of the function responsible for
> > displaying the webview. Additionally, an `AppBar` has been added
> > to the console view on to allow users to easily close the view. To
> > avoid the body of the Scaffold to resize when the keyboard pops up set
> > `resizeToAvoidBottomInset` [0] to `false`
> >
> > The `dart format` command was also ran in the file to fix the file
> > formatting.
>
> is it possible to send dart format patches upfront and as a seperate patch?
>
> that way one can see the actual changes much more easily.
>
> also which version of dart/flutter do you use?
> when i do `dart format` on that file here on current master,
> it does not change the formatting at all
> (but i'm still on flutter 3.29 with dart sdk on 3.7.2)
>
More information about the pve-devel
mailing list