[pve-devel] [PATCH installer v2] gui: always set visible-child-name on disk dialog

Maximiliano Sandoval m.sandoval at proxmox.com
Fri Apr 4 10:39:57 CEST 2025


We show the size selection stack page whenever a filesystem is selected
in the dropdown.

At the moment when one selects certain raid setups (e.g. btrfs RAID10),
then enters the Advanced Options page and then selects certain non-raid
setups (e.g ext4), the `raiddisk` page will still be visible since the
visible-child (and visible-child-name) property still points to it.

Reported-by: Alexander Zeidler <a.zeidler at proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval at proxmox.com>
---

Differences from v1:
 - Improve commit message
 - Describe better the reproducer in the commit

 proxinstall | 1 +
 1 file changed, 1 insertion(+)

diff --git a/proxinstall b/proxinstall
index 9bbd2f9..03235ac 100755
--- a/proxinstall
+++ b/proxinstall
@@ -1357,6 +1357,7 @@ sub create_hdoption_view {
 	    $options_stack->set_visible_child_name("raiddisk");
 	} else {
 	    $target_hd_label->set_text("Target Harddisk");
+	    $options_stack->set_visible_child_name("hdsize");
 	}
 
 	if ($raid) {
-- 
2.39.5





More information about the pve-devel mailing list