[pve-devel] applied: [PATCH installer] proxinstall: replace usage of hacky `mngmt_nic_id` config option

Thomas Lamprecht t.lamprecht at proxmox.com
Fri Apr 4 10:33:55 CEST 2025


Am 24.03.25 um 14:19 schrieb Christoph Heiss:
> The option was more or less a hack from the beginning anyway, introduced
> during the split of the GUI and the installation configuration.
> 
> The required information is already there from `mngmt_nic` - which
> carries the name of the network interface - and is easily reused to
> replace the functionality.
> 
> In short, the `mngmt_nic_id` setting was only used to check whether
> another NIC was selected, avoiding needless updates to the IP address
> and mask textboxes.
> 
> Signed-off-by: Christoph Heiss <c.heiss at proxmox.com>
> ---
>  Proxmox/Install/Config.pm | 6 ------
>  proxinstall               | 9 ++++-----
>  2 files changed, 4 insertions(+), 11 deletions(-)
> 
>

applied, thanks! lets see if anything subtle breaks ^^




More information about the pve-devel mailing list