[pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB

[Mira Limbeck]

On 11/19/24 12:55, Maximiliano Sandoval wrote:
> 
> Mira Limbeck <m.limbeck at proxmox.com> writes:
> 
>> Signed-off-by: Mira Limbeck <m.limbeck at proxmox.com>
>> ---
>>  Proxmox/Install.pm | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
>> index c64e1d4..da8fb55 100644
>> --- a/Proxmox/Install.pm
>> +++ b/Proxmox/Install.pm
>> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
>>  	my $maxvz = Proxmox::Install::Config::get_maxvz();
>>  	if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
>>  	    Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
>> +	} elsif ($iso_env->{product} eq 'pve') {
>> +	    Proxmox::UI::message(
>> +		"Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
> 
> Is "Maximum" intentionally uppercased?
> 
See v2:
https://lore.proxmox.com/pve-devel/20241119111241.97092-1-m.limbeck@proxmox.com/T/#u
Forgot to change `,` to `.` when changing the text.

>> +	    );
>>  	}
>>  	$datadev = undef;
>>      }
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
>