[pve-devel] [PATCH installer] post-hook: add `$version` field describing document schema version

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 12 15:29:55 CET 2024


Am 12.11.24 um 15:06 schrieb Christoph Heiss:
> On Tue, Nov 12, 2024 at 02:44:48PM +0100, Thomas Lamprecht wrote:
>> maybe still use $format-version or $hook-version or the like for the
>> serialized key? I.e., to even better convey that this is, e.g., not some
>> version from the installer or product.
> 
> What do you think about
> 
>     "$hook": { "version": "1.0" }`
> 
> maybe, thereby making it a bit more structured from the start?
> Esp. when thinking about future expansions, if we ever want to add
> additional metadata fields.
> 
> As we're already on the topic of future changes.
> 
> But no hard feelings, otherwise I'd just go with `$hook-version`.

both sound fine to me, I first thought $hook-version is more greppable,
but that is not really relevant here as the tool processing this needs
to know json already anyway to do so in a sensible manner, so your
proposal seems good to me too, feel free to chose whatever you prefer.




More information about the pve-devel mailing list