[pve-devel] applied: [PATCH manager] ui: fix pbs storage edit reset behavior

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 12 14:23:42 CET 2024


Am 24.04.24 um 13:03 schrieb Dominik Csapak:
> two similar things to fix here:
> * the 'crypt-allow-edit' field was not submitted, but it's value was
>   only ever set with a bind, so a reset always set it to it's
>   default 'false' value (disabling the radio buttons, even when
>   it was not visible)
> 
> * the initial value of the 'keep' variant of the radiofield was decided
>   only from 'isCreate' (via the 'checked' cbind), but should have been
>   decided by whether there was an encryption key or not.
> 
> both are fixed by setting the values in the 'setValue' method
> explicitly
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
>  www/manager6/storage/PBSEdit.js | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
>

applied with Fiona's R-b and T-b, thanks!




More information about the pve-devel mailing list