[pve-devel] [PATCH manager] fix #5847: ui: gettextize several strings in ui

[Timothy Nicholson]

> Dominik Csapak <d.csapak at proxmox.com> hat am 12.11.2024 10:16 CET geschrieben:
> 
>  
> one comment inline
> 
> On 11/11/24 12:35, Timothy Nicholson wrote:
> > Several strings that should probably also be translated now use
> > the gettext function to be translated.
> > 
> > Signed-off-by: Timothy Nicholson <t.nicholson at proxmox.com>
> > ---
> > [0]: https://bugzilla.proxmox.com/show_bug.cgi?id=5847
> > 
> >   www/manager6/Workspace.js              |  2 +-
> >   www/manager6/ceph/OSD.js               |  6 +++---
> >   www/manager6/ceph/OSDDetails.js        |  2 +-
> >   www/manager6/form/VMCPUFlagSelector.js | 24 ++++++++++++------------
> >   www/manager6/qemu/ProcessorEdit.js     |  2 +-
> >   www/manager6/window/Settings.js        |  6 +++---
> >   6 files changed, 21 insertions(+), 21 deletions(-)
> > 
> > diff --git a/www/manager6/Workspace.js b/www/manager6/Workspace.js
> > index 52c66108..56dde151 100644
> > --- a/www/manager6/Workspace.js
> > +++ b/www/manager6/Workspace.js
> > @@ -388,7 +388,7 @@ Ext.define('PVE.StdWorkspace', {
> >   				    },
> >   				},
> >   				{
> > -				    text: 'TFA',
> > +				    text: gettext('TFA'),
> 
> is it a good idea to translate this? it's mostly a technical term (which we generally don't 
> translate), but i'd be swayed if there is an actual example where a language want
> to have that translated...

Some languages already translate TFA as 2FA (e.g. German) and TFA is already translated in other parts of the UI.