[pve-devel] applied: [PATCH v2 common] REST environment: warn helpers: also log messages to syslog
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon Nov 11 19:41:07 CET 2024
Am 09.02.24 um 15:15 schrieb Fiona Ebner:
> for better visibility. When not in a task, warnings from these helpers
> are only logged to STDERR, which is particularly unhelpful in case of
> daemons. This is the main motivation behind this change.
>
> For tasks, warnings from these helpers are already more visible on the
> UI side, but when looking at the syslog, one can only see the warning
> count from the task right now, not the actual messages. This is
> another reason in favor of the change.
>
> Reported-by: Friedrich Weber <f.weber at proxmox.com>
> Suggested-by: Thomas Lamprecht <t.lamprecht at proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner at proxmox.com>
> ---
>
> Changes in v2:
> * Go with the approach suggested by Thomas.
>
> src/PVE/RESTEnvironment.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
Albeit I'm not 100% sure how this will work out, my gut is not always right,
and it still seems more than sensible enough to try, so:
applied, thanks!
More information about the pve-devel
mailing list