[pve-devel] applied: [PATCH common 1/2] fix #5454: net: check names for vlan bridge slave interfaces

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Nov 11 19:36:59 CET 2024


Am 25.09.24 um 13:39 schrieb Daniel Kral:
> Adds a check for the name of VLAN bridge slave interfaces, which are
> created on non VLAN-aware bridges. These checks mimics what is done when
> parsing an interface name in iproute2 [0], which includes a name size
> check, an empty string check and checking for invalid characters.
> 
> Without this check, creating a VLAN bridge slave interface, where the
> length of the string "<iface>.<vlanid>" will be greater than or equal to
> 16 characters, resulted in the following error message from `ip` itself:
> 
>> Error: argument "<iface>.<vlanid>" is wrong: "name" not a valid ifname
> 
> [0] https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/lib/utils.c?h=v6.1.0#n825
> 
> Signed-off-by: Daniel Kral <d.kral at proxmox.com>
> ---
>  src/PVE/Network.pm | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
>

applied both patches, thanks!




More information about the pve-devel mailing list