[pve-devel] [PATCH storage] lvm: avoid warning due to human-readable text in vgs output

Fiona Ebner f.ebner at proxmox.com
Fri Jan 12 16:45:05 CET 2024

Am 12.01.24 um 16:11 schrieb Friedrich Weber:
> On 12/01/2024 11:28, Fabian Grünbichler wrote:
>>> The vgs message is printed to stdout, so we could do something like
>>> warn $line if !defined($size);
>>> ?
>> yep, that would be an option (warn+return ;))
> Right, thanks. Thinking about this some more, printing a user-visible
> warning sounds more sensible than suppressing the warning complete
> (either by passing `-qq` or ignoring the line, as in the current patch).
> I'll send a v2.

If we go for the warn route, please prefix the line appropriately. This
is in a function rather deep down that's executed during various
different top-level operations, so it should be made clear where it
comes from.

More information about the pve-devel mailing list