[pve-devel] applied-series: [PATCH installer 0/6] switch low-level installer protocol to json

Thomas Lamprecht t.lamprecht at proxmox.com
Mon Feb 26 15:07:42 CET 2024


Am 06/12/2023 um 12:34 schrieb Christoph Heiss:
> This switches the stdio-protocol for the low-level installer from
> simple, line-based messages to JSON.
> 
> This solves a number of problems, most prominently that messages can now
> contain multiline text (or for that matter, any kind of data), as JSON
> handles that transparently.
> 
> The actual "meaty" changes are in #3, the others are either some simple
> cleanups or test infra.
> 
> I have also included a testsuite for both the Perl side of things, as
> well as the TUI, to ensure that it works and cannot be accidently broken
> easily in the future.
> 
> Tested this by installing of PVE and PBS.
> 
> Christoph Heiss (6):
>   low-level: align wording of finish message
>   ui: stdio: log error if display_html() is called on stdio backend
>   tui, ui: switch over to JSON-based protocol
>   test: add tests for UI^2 stdio protocol
>   buildsys: setup proper test environment for testsuite
>   tui: install progress: add tests for UI^2 stdio protocol
> 
>  Makefile                                      |   9 +-
>  Proxmox/UI/StdIO.pm                           |  43 ++--
>  proxmox-low-level-installer                   |   2 +-
>  .../src/views/install_progress.rs             | 195 +++++++++++++-----
>  test/Makefile                                 |   6 +-
>  test/ui2-stdio.pl                             |  96 +++++++++
>  6 files changed, 280 insertions(+), 71 deletions(-)
>  create mode 100755 test/ui2-stdio.pl
> 

forgot to write:

applied series, with fix up for bogus prototype definition, thanks!




More information about the pve-devel mailing list