[pve-devel] applied: [PATCH manager v2 1/2] ui: form: add TwoColumnContainer

[Thomas Lamprecht]

Am 22/04/2024 um 10:16 schrieb Dominik Csapak:
> this is a container, showing a widget on the left column and another one
> on the right one, with a (default) flex ratio of 1:2
> 
> this is helpful when wanting fields to align vertically in an input
> panel that have different height (e.g. because of text wrapping)
> 
> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> ---
> changes from v1:
> * make the container more generic as a simple container that holds two
>   widgets, so it can be useful in more situations
> 
>  www/manager6/Makefile                   |  1 +
>  www/manager6/form/TwoColumnContainer.js | 53 +++++++++++++++++++++++++
>  2 files changed, 54 insertions(+)
>  create mode 100644 www/manager6/form/TwoColumnContainer.js
> 
>

applied both patches with some rework, thanks!

Reworked was:
- startWidget -> startColumn and same for the end one

- expose both start and end flex, and name it flex again as it's then not
  guaranteed to be a 1/x ratio anymore, and flex is more widely used.

- exposed the columnPadding, can be nice to make it narrower for some UIs

- fixed the eslint warnings of the second patch and integrated changes from
  the first one also in there.