[pve-devel] [PATCH manager v2 2/2] ui: use pveTwoColumnContainer for the advanced backup options

Fiona Ebner f.ebner at proxmox.com
Mon Apr 22 10:28:14 CEST 2024


Am 22.04.24 um 10:22 schrieb Fiona Ebner:
> Am 22.04.24 um 10:16 schrieb Dominik Csapak:
>> where we generally want to show a field on the left, but a description
>> on the right.
>>
>> merges the column1/2/B into just items.
>>
>> Signed-off-by: Dominik Csapak <d.csapak at proxmox.com>
> 
> Getting eslint errors:
> 
>> [./panel/BackupAdvancedOptions.js]:
>> WARN: line 158 col 16: key-spacing - Missing space before value for key 'endWidget'. (*)
>> WARN: line 161 col 7: comma-dangle - Missing trailing comma. (*)
> 
> I noticed that the "Fallback (default)" emptytext does not fit in the
> value fields. Could you improve the spacing there?
> 

Other than that, both patches:

Tested-by: Fiona Ebner <f.ebner at proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner at proxmox.com>




More information about the pve-devel mailing list