[pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot

[Alexander Zeidler]

On Thu, 2024-04-18 at 13:05 +0200, Mira Limbeck wrote:
> On 4/18/24 11:16, Alexander Zeidler wrote:
> > to get a first clue for debugging passthrough and similar issues, when
> > no dmesg output has been provided yet.
> > 
> > Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
> > ---
> > v2:
> > * move away from dmesg base
> > * only print kernel command line (boot times can be added by another patch)
> > 
> > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062342.html
> > 
> > 
> >  PVE/Report.pm | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/PVE/Report.pm b/PVE/Report.pm
> > index 53ffdcbb..a8c1cab9 100644
> > --- a/PVE/Report.pm
> > +++ b/PVE/Report.pm
> > @@ -31,6 +31,7 @@ my $init_report_cmds = sub {
> >  	    cmds => [
> >  		'hostname',
> >  		'date -R',
> > +		'cat /proc/cmdline',
> >  		'pveversion --verbose',
> >  		'cat /etc/hosts',
> >  		'pvesubscription get',
> Tested the whole patch series.
> Looks good so far, especially the cmdline and APT information is nice to
> have.
> 
> With the added APT information between subscription info, lscpu and
> /cluster/resources, would it maybe make sense to move `pvesubscription
> get` and `pvesh get /cluster/resources` next to each other,

Good idea.

>  and `lscpu`
> to the hardware section where we have all the `dmidecode` output, and
> `lspci`?

Maybe placing `lscpu` above or below the potentially accepted (compact
version) of the new memory output? I think it makes sense to start with the
mainboard, followed by cpu/memory and ending with the extensive `lspci`.

The move of `lscpu` was already discussed in v1 here:

[PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections
https://lists.proxmox.com/pipermail/pve-devel/2024-April/062871.html

but I decided to drop it since it was related to another now dropped change.


> Except for the `dmidecode -t16,17` command needing a space for
> consistency, I'm fine with any of the additions.
> So consider the whole series:
> 
> Reviewed-by: Mira Limbeck <m.limbeck at proxmox.com>
> Tested-by: Mira Limbeck <m.limbeck at proxmox.com>