[pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster info to more appropriate sections

[Alexander Zeidler]

On Mon, 2024-03-25 at 09:11 +0100, Thomas Lamprecht wrote:
> And why are those more appropriate? Both fit's the general "always important"
> section, so even though they fit the section you moved them too, they also
> fit the general one, so some actual reasoning here would be good..
> 
> On 22/03/2024 14:59, Alexander Zeidler wrote:
> > Signed-off-by: Alexander Zeidler <a.zeidler at proxmox.com>
> > ---
> >  PVE/Report.pm | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/PVE/Report.pm b/PVE/Report.pm
> > index 2c2a5e12..505629c7 100644
> > --- a/PVE/Report.pm
> > +++ b/PVE/Report.pm
> > @@ -41,8 +41,6 @@ my $init_report_cmds = sub {
> >  		'cat /etc/apt/sources.list',
> >  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.list') },
> >  		sub { dir2text('/etc/apt/sources.list.d/', '.+\.sources') },
> > -		'lscpu',

Because of the commands from [PATCH manager 9/9]:
+  'apt list *microcode 2>/dev/null | column -tL',
+  'dmesg | grep -i "microcode\|vuln"',
which are associated to the lscpu output. But due to your suggestions in
[PATCH manager 9/9], like:

> I'm wondering if instead of having a handful of dmesg + grep instances
> it makes more sense to just add the whole dmesg output as separate
> file.

both patches can be dropped.

> > -		'pvesh get /cluster/resources --type node --output-format=yaml',

This move just felt more appropriate since we have a dedicated cluster section.
Beside that we often jump to or filter for keywords, so the actual position might
not be that important. I'm fine with dropping this change and stick with the
position we are used to.

> >  	    ],
> >  	},
> >  	'system-load' => {
> > @@ -96,6 +94,7 @@ my $init_report_cmds = sub {
> >  	    order => 60,
> >  	    cmds => [
> >  		'pvecm nodes',
> > +		'pvesh get /cluster/resources --type node --output-format=yaml',
> >  		'pvecm status',
> >  		'cat /etc/pve/corosync.conf 2>/dev/null',
> >  		'ha-manager status',
> > @@ -106,6 +105,7 @@ my $init_report_cmds = sub {
> >  	    order => 70,
> >  	    cmds => [
> >  		'dmidecode -t bios',
> > +		'lscpu',
> >  		'lspci -nnk',
> >  	    ],
> >  	},
>