[pve-devel] applied: [PATCH manager v3] api: ceph: improve reporting of ceph OSD memory usage
Stefan Hanreich
s.hanreich at proxmox.com
Mon Sep 4 15:47:35 CEST 2023
On 9/4/23 15:14, Thomas Lamprecht wrote:
> Am 04/09/2023 um 11:18 schrieb Stefan Hanreich:
>> ---
>> Changes from v2:
>> * closing the file handle after using it
>> * improved error message when failing to open proc file
>> * add hint in the UI that we are using PSS
>> * mentioned Aaron's involvement in commit message
>
> missing factoring this out to own helper to avoid crowding the API endpoint
> code itself to much, like asked in my review.. If you don't agree please
> state that at least, ideally with a reason..
>
Sorry, I misunderstood the answer as don't factor it out at all for now
- but I see now that this was specifically related to ProcFSTools...
More information about the pve-devel
mailing list