[pve-devel] applied: [PATCH manager v3] api: ceph: improve reporting of ceph OSD memory usage

[Thomas Lamprecht]

Am 04/09/2023 um 11:18 schrieb Stefan Hanreich:
> ---
> Changes from v2:
> * closing the file handle after using it
> * improved error message when failing to open proc file
> * add hint in the UI that we are using PSS
> * mentioned Aaron's involvement in commit message

missing factoring this out to own helper to avoid crowding the API endpoint
code itself to much, like asked in my review.. If you don't agree please
state that at least, ideally with a reason..

> 
> Changes from v1:
>  * now returns 0 instead of null in case of stopped OSDs in order to
>  preserve backwards compatibility
> 
>  PVE/API2/Ceph/OSD.pm            | 21 ++++++++++++++++-----
>  www/manager6/ceph/OSDDetails.js |  2 +-
>  2 files changed, 17 insertions(+), 6 deletions(-)
> 
>

applied, with two follow ups, a clean-up one for previous existing code
and factoring this out and adapting error handling as second, thanks!