[pve-devel] [PATCH installer v2 0/8] refactor and improve installation progress

Christoph Heiss c.heiss at proxmox.com
Fri Nov 10 15:17:18 CET 2023

First #5 patches splits out the gigantic install progress dialog into its
own module; then applying some divide-and-conquer to make it more
readable and get the inner >150 lines closure down to a more
maintainable state. Purely code movement without any functional changes.

Patch #6 improves the error handling during the interaction with the
low-level installer, by providing the user with better error messages in
case something goes wrong.

Patch #7 does some code de-duplication for the low-lever installer.

Patch #8 improves the auto-reboot message/UX by counting down the
timeout, to match its GUI counterpart.

v1: https://lists.proxmox.com/pipermail/pve-devel/2023-July/058510.html

Notable changes v1 -> v2:
  * rebased on latest master
  * added patch #2, split out from #1

Christoph Heiss (8):
  tui: move install progress dialog into own view module
  tui: install_progress: move progress task into own function
  tui: install_progress: split out low-level installer spawing into own
  tui: install_progress: split out reboot handling into own function
  tui: install_progress: split out prompt logic into own function
  tui: install_progress: handle errors in ui message loop more
  low-level: avoid open-coding config reading, parsing and merging
  low-level, tui: count down auto-reboot timeout

 proxmox-installer-common/src/setup.rs         |  22 +-
 proxmox-low-level-installer                   |  70 +++--
 proxmox-tui-installer/src/main.rs             | 233 +---------------
 .../src/views/install_progress.rs             | 253 ++++++++++++++++++
 proxmox-tui-installer/src/views/mod.rs        |   3 +
 5 files changed, 316 insertions(+), 265 deletions(-)
 create mode 100644 proxmox-tui-installer/src/views/install_progress.rs


More information about the pve-devel mailing list